Skip to content

chore: update Digital Ocean example template (#11528) #11535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 11, 2024
Merged

chore: update Digital Ocean example template (#11528) #11535

merged 3 commits into from
Jan 11, 2024

Conversation

bamhm182
Copy link
Contributor

@bamhm182 bamhm182 commented Jan 9, 2024 •
edited by matifali
Loading

Made the following changes to Digital Ocean example template:

  • Alphabetized Droplet Images
  • Removed no longer existent Fedora 35, Fedora 36, Debian 10, Rocky Linux 8.4 Droplet Images
  • Added new Fedora 38, Fedora 39, Debian 10, AlmaLinux 8, AlmaLinux 9 Droplet Images
  • Added AlmaLinux icon
  • Added s-1vcpu-512mb-10gb Droplet size. Commented due to diverse set of non-supported regions
  • Commented s-8vcpu-16gb Droplet Size due to requiring a Digital Ocean support ticket to use
  • Decreased maximum home drive size to 100 GB due to requiring a Digital Ocean support ticket to use
  • Alphabetized and added country names to regions
  • Made various improvements to coder_agent.main's metadata, primarily to resolve previous invalid home volume usage checks

Closes #11528

@cdr-bot cdr-bot bot added the community Pull Requests and issues created by the community. label Jan 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2024 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@bamhm182
Copy link
Contributor Author

bamhm182 commented Jan 9, 2024

After reviewing the CLA, I do not own the copyright to the included almalinux.svg and believe I should remove it alongside the AlmaLinux entries in this template, though I would like someone to verify that first.

@ammario
Copy link
Member

ammario commented Jan 10, 2024

After reviewing the CLA, I do not own the copyright to the included almalinux.svg and believe I should remove it alongside the AlmaLinux entries in this template, though I would like someone to verify that first.

Per https://github.com/AlmaLinux/wiki/blob/master/LICENSE, we're good to use it.

@bamhm182
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

cdrcommunity added a commit to coder/cla that referenced this pull request Jan 10, 2024
@cdrcommunity
@bamhm182 has signed the CLA in coder/coder#11535
3d859cf
@bamhm182
Copy link
Contributor Author

Thanks! Requested changes have been made and pushed. Should be good to go now.

matifali
matifali approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contribution.

@matifali matifali enabled auto-merge (squash) January 10, 2024 23:55
@matifali matifali merged commit 4e5367c into coder:main Jan 11, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matifali matifali matifali approved these changes

Assignees

@bamhm182 bamhm182

Labels
community Pull Requests and issues created by the community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Digital Ocean Template Issues
3 participants
@bamhm182 @ammario @matifali