Skip to content

chore: update sqlc to 1.25.0 #11538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 10, 2024
Merged

chore: update sqlc to 1.25.0 #11538

merged 3 commits into from
Jan 10, 2024

Conversation

code-asher
Copy link
Member

@code-asher code-asher commented Jan 10, 2024

The flake.lock was updated and now uses sqlc 1.25.0, so update the Dockerfile and CI to match and regen so nix and non-nix users are all generating the same thing.

We could also downgrade sqlc back down to 1.24.0 in the flake, but I think upgrading is easier.

The flake.lock was updated and now uses sqlc 1.25.0, so update the
Dockerfile to match and regen.
@code-asher code-asher marked this pull request as ready for review January 10, 2024 00:52
@code-asher code-asher requested a review from coadler January 10, 2024 00:52
@code-asher
Copy link
Member Author

Image build failing with Organization free trial period has ended 😕

@coadler
Copy link
Contributor

coadler commented Jan 10, 2024

I think you'll also have to change .github/actions/setup-sqlc/action.yaml to the new version

@code-asher
Copy link
Member Author

I think you'll also have to change .github/actions/setup-sqlc/action.yaml to the new version

Thank you! Updated.

@code-asher
Copy link
Member Author

@matifali any idea on the build failure?

@matifali
Copy link
Member

cc: @ammario it's s depot.dev issue

@matifali
Copy link
Member

I have added docker-buildx builder as a fallback, which will build it very slowly instead of failing if there is an issue with the depot.dev

@matifali matifali merged commit d837d66 into main Jan 10, 2024
@matifali matifali deleted the asher/sqlc-1.25.0 branch January 10, 2024 06:19
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2024
Copy link
Member

ammario commented Jan 10, 2024

At least some of the issue is that our trial expired. But I'm also getting this error as I try to fix it by adding a card:

image.png

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants