feat: load variables from tfvars files #11549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
reviewed
Jan 12, 2024
Comment on lines
+112
to
+115
| varsFiles, err = DiscoverVarsFiles(uploadFlags.directory) | ||
| if err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
I could imagine a case where someone had tfvars files lying around unused before, worked around the issue, and left them there. Now we're going to auto-discover them. I'm not sure what this will break.
Should at the very least add an info message about the auto-discovered vars files?
There was a problem hiding this comment.
Ok, I changed the code to print a message alerting about the presence of tfvars 👍
johnstcn
reviewed
Jan 12, 2024
johnstcn
reviewed
Jan 12, 2024
| stringData[attribute.Name] = ctyValue.AsString() | ||
| } else if ctyType.Equals(cty.Number) { | ||
| stringData[attribute.Name] = ctyValue.AsBigFloat().String() | ||
| } else if ctyType.IsTupleType() { |
There was a problem hiding this comment.
I immediately saw this, thought 🤔 "y no switch", and then saw how annoying this is.
There was a problem hiding this comment.
Yes, unfortunately the API isn't too friendly :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8501
This PR expands the
template pushandtemplate createto review.tfvarsand.tfvars.jsonfiles while uploading next template version. CLI will support a flat variable structure:HCL
JSON
{ "region": "us-east-1", "cores": 2, "go_image": ["1.19","1.20","1.21"] }TODO: