fix(site): show wsproxy errors in context in WorkspaceProxyPage #11556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
johnstcn
commented
Jan 10, 2024
•
- Shows the overall report error at the top of the page, if present.
- Shows workspaceproxy errors above warnings inside the corresponding element, if present.
johnstcn
commented
Jan 10, 2024
Comment on lines
149
to
151
| {errors.map((error, i) => ( | ||
| <span key={i}>{error}</span> | ||
| ))} | ||
| {warnings.map((warning, i) => ( | ||
| <span key={i}>{warning}</span> | ||
| ))} |
There was a problem hiding this comment.
I tried turning this into an <ul> and playing around with list-style-type to prefix these with 🚫 or
mtojek
reviewed
Jan 11, 2024
8cbb527 to
5c5e658
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.