Skip to content

feat: add a character counter for fields with length limits #11558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 11, 2024
Merged

feat: add a character counter for fields with length limits #11558

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
17d0dc2
feat: add a character counter for fields with length limits
aslilac Jan 10, 2024
01fe466
🧪
aslilac Jan 11, 2024
985d8d0
add story
aslilac Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add story
  • Loading branch information
@aslilac
aslilac committed Jan 11, 2024
commit 985d8d0474b8ea5b3d65b3ce496dd44b6935c858
2 changes: 1 addition & 1 deletion ...ges/TemplateSettingsPage/TemplateGeneralSettingsPage/TemplateSettingsPageView.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import type { Meta, StoryObj } from "@storybook/react";
import { mockApiError, MockTemplate } from "testHelpers/entities";
import { TemplateSettingsPageView } from "./TemplateSettingsPageView";
import type { Meta, StoryObj } from "@storybook/react";

const meta: Meta<typeof TemplateSettingsPageView> = {
title: "pages/TemplateSettingsPage",
Expand Down
69 changes: 69 additions & 0 deletions site/src/utils/formUtils.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
import type { Meta, StoryObj } from "@storybook/react";
import { type FC } from "react";
import TextField from "@mui/material/TextField";
import { Form } from "components/Form/Form";
import { getFormHelpers } from "./formUtils";
import { useFormik } from "formik";
import { action } from "@storybook/addon-actions";

interface ExampleFormProps {
value?: string;
maxLength?: number;
}

const ExampleForm: FC<ExampleFormProps> = ({ value, maxLength }) => {
const form = useFormik({
initialValues: {
value,
},
onSubmit: action("submit"),
});

const getFieldHelpers = getFormHelpers(form, null);

return (
<Form>
<TextField
label="Value"
rows={2}
{...getFieldHelpers("value", { maxLength })}
/>
</Form>
);
};

const meta: Meta<typeof ExampleForm> = {
title: "utilities/getFormHelpers",
component: ExampleForm,
};

export default meta;
type Story = StoryObj<typeof Form>;

export const UnderMaxLength: Story = {
args: {
value: "a".repeat(98),
maxLength: 128,
},
};

export const CloseToMaxLength: Story = {
args: {
value: "a".repeat(99),
maxLength: 128,
},
};

export const AtMaxLength: Story = {
args: {
value: "a".repeat(128),
maxLength: 128,
},
};

export const OverMaxLength: Story = {
args: {
value: "a".repeat(129),
maxLength: 128,
},
};