Skip to content

fix: publish workspace update on quota failure #11559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

f0ssel
Copy link
Contributor

@f0ssel f0ssel commented Jan 10, 2024

Closes #11192
Before:
Screenshot 2024-01-11 at 10 32 33 AM

After:
Screenshot 2024-01-11 at 10 30 58 AM

@f0ssel f0ssel requested a review from code-asher January 11, 2024 14:23
@f0ssel f0ssel marked this pull request as ready for review January 11, 2024 14:23
@f0ssel f0ssel requested a review from kylecarbs January 11, 2024 15:54
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh yup that makes sense. Looks good to me!

@f0ssel f0ssel merged commit 5b122d1 into main Jan 11, 2024
@f0ssel f0ssel deleted the f0ssel/publish-on-quota-fail branch January 11, 2024 19:59
@github-actions github-actions bot locked and limited conversation to collaborators Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When workspace build fails due to Quota check, the UI does not give proper indication
2 participants