Skip to content

fix: ensure frontend is built in make install #1157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2022
Merged

fix: ensure frontend is built in make install #1157

merged 1 commit into from
Apr 25, 2022

Conversation

coadler
Copy link
Contributor

@coadler coadler commented Apr 25, 2022

No description provided.

@coadler coadler self-assigned this Apr 25, 2022
@coadler coadler requested a review from kylecarbs April 25, 2022 20:01
@codecov
Copy link

codecov bot commented Apr 25, 2022 •
edited
Loading

Codecov Report

Merging #1157 (d4ef9bc) into main (82552a9) will increase coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1157      +/-   ##
==========================================
+ Coverage   66.43%   66.57%   +0.13%     
==========================================
  Files         263      263              
  Lines       16416    16427      +11     
  Branches      156      156              
==========================================
+ Hits        10906    10936      +30     
+ Misses       4388     4375      -13     
+ Partials     1122     1116       -6
Flag Coverage Δ
unittest-go-macos-latest 53.94% <ø> (+0.03%) ⬆️
unittest-go-postgres- 65.83% <ø> (+0.06%) ⬆️
unittest-go-ubuntu-latest 56.53% <ø> (+0.14%) ⬆️
unittest-go-windows-2022 53.57% <ø> (+0.04%) ⬆️
unittest-js 67.42% <ø> (+0.13%) ⬆️
Impacted Files Coverage Δ
provisionerd/provisionerd.go 76.23% <0.00%> (-0.54%) ⬇️
site/src/components/SignInForm/SignInForm.tsx 100.00% <0.00%> (ø)
.../PreferencesAccountForm/PreferencesAccountForm.tsx 100.00% <0.00%> (ø)
peer/conn.go 80.20% <0.00%> (+0.50%) ⬆️
coderd/provisionerdaemons.go 63.29% <0.00%> (+1.01%) ⬆️
coderd/workspaceagents.go 61.78% <0.00%> (+1.42%) ⬆️
peerbroker/listen.go 89.07% <0.00%> (+1.68%) ⬆️
pty/pty_windows.go 70.14% <0.00%> (+1.89%) ⬆️
agent/agent.go 68.49% <0.00%> (+2.32%) ⬆️
provisioner/echo/serve.go 59.20% <0.00%> (+2.40%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82552a9...d4ef9bc. Read the comment docs.

@coadler coadler merged commit 0c9f27c into main Apr 25, 2022
@coadler coadler deleted the colin/build-fe branch April 25, 2022 20:24
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
@coadler @kylecarbs
fix: ensure frontend is built in make install (#1157)
28a200f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees

@coadler coadler

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.
3 participants
@coadler @kylecarbs @misskniss