Skip to content

fix(site): improve rendering of provisioner tags #11575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 11, 2024
Merged

Conversation

johnstcn
Copy link
Member

Attempt at fixing #11542

  • For tags with boolean values (["true", "1", "yes", "false", "0", "no", ""]), renders as BooleanPill.
  • Otherwise, renders a Pill with key: value.

image

@johnstcn johnstcn self-assigned this Jan 11, 2024
@matifali
Copy link
Member

I think this serves the purpose. 🌮 cool design. 👍🏼

@f0ssel
Copy link
Contributor

f0ssel commented Jan 11, 2024

I'm also looking into rendering tags in #11360 and I find the boolean tags to be a little confusing at first glance. It may be that I prefer verbosity, but I think I would rather have the boolean values displayed the same as the key value pairs. So something like ( *checkmark* tag_true: true ) and ( *checkmark* tag_1: 1 ) so you know the exact values if you want to run a new provisioner. Otherwise I like the design and use of logos and color.

@johnstcn johnstcn merged commit f3d091f into main Jan 11, 2024
@johnstcn johnstcn deleted the cj/ui-provisionerd-tags branch January 11, 2024 17:42
@github-actions github-actions bot locked and limited conversation to collaborators Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants