Skip to content

fix(site): fix resource selection when workspace resources change #11581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 12, 2024
Merged

fix(site): fix resource selection when workspace resources change #11581

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1222a24
fix(site): fix resource selection when workspace resources change
BrunoQuaresma Jan 11, 2024
8c6e334
Apply improvements from PRs
BrunoQuaresma Jan 12, 2024
1d2e8f3
Use effect event
BrunoQuaresma Jan 12, 2024
032c3a1
Merge branch 'main' of https://github.com/coder/coder into bq/fix-emp…
BrunoQuaresma Jan 12, 2024
ec2282e
Add more comments about the solution
BrunoQuaresma Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use effect event
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed Jan 12, 2024
commit 1d2e8f376215615cbef62ae746588ff6a83e05f1
21 changes: 14 additions & 7 deletions site/src/pages/WorkspacePage/useResourcesNav.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { WorkspaceResource } from "api/typesGenerated";
import { useTab } from "hooks";
import { useEffectEvent } from "hooks/hookPolyfills";
import { useCallback, useEffect, useMemo } from "react";

export const resourceOptionId = (resource: WorkspaceResource) => {
Expand All @@ -24,14 +25,20 @@ export const useResourcesNav = (resources: WorkspaceResource[]) => {
);

const selectedResource = resources.find(isSelected);

const onSelectedResourceChange = useEffectEvent(
(previousResource?: WorkspaceResource) => {
const hasResourcesWithAgents =
firstResource &&
firstResource.agents &&
firstResource.agents.length > 0;
if (!previousResource && hasResourcesWithAgents) {
resourcesNav.set(resourceOptionId(firstResource));
}
},
);
useEffect(() => {
const hasResourcesWithAgents =
firstResource && firstResource.agents && firstResource.agents.length > 0;
if (!selectedResource && hasResourcesWithAgents) {
resourcesNav.set(resourceOptionId(firstResource));
}
}, [firstResource, resourcesNav, selectedResource]);
onSelectedResourceChange(selectedResource);
}, [onSelectedResourceChange, selectedResource]);

const select = useCallback(
(resource: WorkspaceResource) => {
Expand Down