-
Notifications
You must be signed in to change notification settings - Fork 881
feat: batch workspace updates #11583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Are you checking if a workspace is already on the latest version? We should start it again in such cases. |
it now checks if they're already on the latest version, but it seems like the consensus is to leave up-to-date workspaces untouched (including stopped ones) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good. I'm wondering if we should add integration tests for all 4 scenarios you described in the PR description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this also looks good to me, too. Just had one question about a change that could make the code easier to maintain down the line, but that I don't have enough context to say is a good change or not
just need to get storybook working and this'll be ready. but the component uses |
Closes #11326
Screen.Recording.2024-01-16.at.4.52.31.PM.mov