chore: remove duplicate validate calls on same oauth token #11598
+119
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
approved these changes
Jan 12, 2024
Comment on lines
+214
to
+219
| if options.NewTicker == nil { | ||
| options.NewTicker = func(duration time.Duration) (tick <-chan time.Time, done func()) { | ||
| ticker := time.NewTicker(duration) | ||
| return ticker.C, ticker.Stop | ||
| } | ||
| } |
There was a problem hiding this comment.
This is OK for now but we should probably swap this out for something better later on 🕰️
There was a problem hiding this comment.
I agree. Some fake clock solution would be ideal, then we can use across all tests more generally.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
If we have an invalid token in the db, we should not spam github with the same validate call over and over.
I am not sure how often this was hit in production, since most keys that go invalid expire, which we already check for.
This happens if someone manually revokes a token.
Related to #10853
Thoughts
I think this should really be solved more generally. We should remember when a token is invalid, and not try again. The browser and other things also trigger this call, which we could deduplicate with a cache.
This would save some calls in all cases.
The metrics indicate we are potentially sending more calls from TokenSource thenValidate though.