Skip to content

refactor(site): make cosmetic changes on agent logs #11601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2024
Merged

refactor(site): make cosmetic changes on agent logs #11601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
refactor(site): chosmetic changes on agent logs
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed Jan 12, 2024
commit c1700c71b42a4bef47ebe60d11779ee56d47c9ce
34 changes: 19 additions & 15 deletions site/src/components/Resources/AgentRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,20 +318,22 @@ export const AgentRow: FC<AgentRowProps> = ({
<img
src={logSource.icon}
alt=""
width={16}
height={16}
width={14}
height={14}
css={{
marginRight: 8,
flexShrink: 0,
}}
/>
);
} else {
icon = (
<div
css={{
width: 16,
height: 16,
width: 14,
height: 14,
marginRight: 8,
flexShrink: 0,
background: determineScriptDisplayColor(
logSource.display_name,
),
Expand Down Expand Up @@ -361,34 +363,36 @@ export const AgentRow: FC<AgentRowProps> = ({
icon = (
<div
css={{
minWidth: 16,
width: 16,
height: 16,
width: 14,
height: 14,
marginRight: 8,
display: "flex",
justifyContent: "center",
position: "relative",
flexShrink: 0,
}}
>
<div
css={{
className="dashed-line"
css={(theme) => ({
height: nextChangesSource ? "50%" : "100%",
width: 4,
background: "hsl(222, 31%, 25%)",
width: 2,
background: theme.experimental.l1.outline,
borderRadius: 2,
}}
})}
/>
{nextChangesSource && (
<div
css={{
height: 4,
className="dashed-line"
css={(theme) => ({
height: 2,
width: "50%",
top: "calc(50% - 2px)",
left: "calc(50% - 1px)",
background: "hsl(222, 31%, 25%)",
background: theme.experimental.l1.outline,
borderRadius: 2,
position: "absolute",
}}
})}
/>
)}
</div>
Expand Down
23 changes: 20 additions & 3 deletions site/src/components/WorkspaceBuildLogs/Logs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ const styles = {
wordBreak: "break-all",
display: "flex",
alignItems: "center",
fontSize: 14,
fontSize: 13,
color: theme.palette.text.primary,
fontFamily: MONOSPACE_FONT_FAMILY,
height: "auto",
Expand All @@ -131,14 +131,29 @@ const styles = {

"&.error": {
backgroundColor: theme.experimental.roles.error.background,
color: theme.experimental.roles.error.text,

"& .dashed-line": {
backgroundColor: theme.experimental.roles.error.outline,
},
},

"&.debug": {
backgroundColor: theme.experimental.roles.info.background,
color: theme.experimental.roles.info.text,

"& .dashed-line": {
backgroundColor: theme.experimental.roles.info.outline,
},
},

"&.warn": {
backgroundColor: theme.experimental.roles.warning.background,
color: theme.experimental.roles.warning.text,

"& .dashed-line": {
backgroundColor: theme.experimental.roles.warning.outline,
},
},
}),
space: {
Expand All @@ -153,8 +168,10 @@ const styles = {
display: "inline-block",
color: theme.palette.text.secondary,
}),
number: {
number: (theme) => ({
width: 32,
textAlign: "right",
},
flexShrink: 0,
color: theme.palette.text.disabled,
}),
} satisfies Record<string, Interpolation<Theme>>;