Skip to content

chore: improve fake IDP script #11602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jan 15, 2024
Merged

chore: improve fake IDP script #11602

merged 9 commits into from
Jan 15, 2024

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Jan 12, 2024 •
edited
Loading

  • Custom expirary
    • Set some super quick expire times.
  • Enforce expiraries
    • Expires are now enforced on the idp
  • Static values
    • The client_id, client_secret, etc are static. So you can rerun the idp server without changing coderd settings.
  • Logging
    • Log all http hits so you can see what idp routes are being hit

@Emyrk Emyrk marked this pull request as ready for review January 12, 2024 23:16
@Emyrk Graphite App
Copy link
Member Author

Emyrk commented Jan 12, 2024 •
edited
Loading

In this stack: 🔧 Improve fake IDP script, fix OAuth links on external auth page(?)

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Emyrk and the rest of your teammates on Graphite Graphite

This was referenced Jan 12, 2024
Closed
Closed
@Emyrk Emyrk force-pushed the stevenmasley/expire_idp_test branch from dcc1b4a to d4d8b1c Compare January 12, 2024 23:22
@Emyrk Emyrk force-pushed the stevenmasley/expire_idp_test branch from aaf54d5 to 51952cd Compare January 12, 2024 23:37
@Emyrk Emyrk changed the title chore: fake IDP script improvements chore: improve fake IDP script Jan 12, 2024
@Emyrk Emyrk requested a review from johnstcn January 12, 2024 23:40
@Emyrk Emyrk merged commit 5087f7b into main Jan 15, 2024
@Emyrk Emyrk deleted the stevenmasley/expire_idp_test branch January 15, 2024 16:01
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnstcn johnstcn johnstcn approved these changes

Assignees

@Emyrk Emyrk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Emyrk @johnstcn