Skip to content

fix: Use Lax mode for OAuth redirect cookies #1162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2022
Merged

fix: Use Lax mode for OAuth redirect cookies #1162

merged 1 commit into from
Apr 25, 2022

Conversation

kylecarbs
Copy link
Member

OAuthing was resulting in an error, because Strict
cookies are not sent on redirects.

@kylecarbs
fix: Use Lax mode for OAuth redirect cookies
22f2ddd 
OAuthing was resulting in an error, because Strict
cookies are not sent on redirects.
@kylecarbs kylecarbs requested a review from coadler April 25, 2022 20:33
@codecov
Copy link

codecov bot commented Apr 25, 2022 •
edited
Loading

Codecov Report

Merging #1162 (22f2ddd) into main (8f464ce) will decrease coverage by 0.14%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1162      +/-   ##
==========================================
- Coverage   66.53%   66.38%   -0.15%     
==========================================
  Files         263      259       -4     
  Lines       16427    16227     -200     
  Branches      156      156              
==========================================
- Hits        10929    10772     -157     
+ Misses       4377     4348      -29     
+ Partials     1121     1107      -14
Flag Coverage Δ
unittest-go-macos-latest 54.05% <100.00%> (+0.14%) ⬆️
unittest-go-postgres- 65.85% <100.00%> (-0.01%) ⬇️
unittest-go-ubuntu-latest 56.36% <100.00%> (-0.18%) ⬇️
unittest-go-windows-2022 ?
unittest-js 67.42% <ø> (ø)
Impacted Files Coverage Δ
coderd/httpmw/oauth2.go 82.71% <100.00%> (ø)
cli/configssh.go 62.30% <0.00%> (-6.93%) ⬇️
peerbroker/dial.go 77.04% <0.00%> (-6.56%) ⬇️
cli/cliui/agent.go 77.19% <0.00%> (-5.27%) ⬇️
pty/ptytest/ptytest.go 86.95% <0.00%> (-4.35%) ⬇️
cli/templateinit.go 58.62% <0.00%> (-3.45%) ⬇️
peerbroker/listen.go 84.03% <0.00%> (-3.37%) ⬇️
agent/agent.go 63.00% <0.00%> (-3.30%) ⬇️
cli/cliui/provisionerjob.go 76.42% <0.00%> (-2.15%) ⬇️
peer/channel.go 83.81% <0.00%> (-1.74%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f464ce...22f2ddd. Read the comment docs.

@kylecarbs kylecarbs self-assigned this Apr 25, 2022
@kylecarbs kylecarbs enabled auto-merge (squash) April 25, 2022 20:42
@kylecarbs kylecarbs merged commit 759fa5f into main Apr 25, 2022
@kylecarbs kylecarbs deleted the oauthfix branch April 25, 2022 20:42
kylecarbs added a commit that referenced this pull request Jun 10, 2022
@kylecarbs
fix: Use Lax mode for OAuth redirect cookies (#1162)
b8123fe 
OAuthing was resulting in an error, because Strict
cookies are not sent on redirects.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coadler coadler coadler approved these changes

Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylecarbs @coadler