Skip to content

feat: support links with custom icons #11629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 15, 2024
Merged

feat: support links with custom icons #11629

merged 2 commits into from
Jan 15, 2024

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Jan 15, 2024

Fixes: #11611

This PR adds support for custom URL icons for Support Links in the navbar.

Screenshot 2024-01-15 at 15 37 08

coder.yaml:

supportLinks:
  - name: "GitHub"
    target: "https://github.com/coder/coder"
    icon: "bug"
  - name: "Slack"
    target: "https://codercom.slack.com/archives/C014JH42DBJ"
    icon: "https://raw.githubusercontent.com/coder/coder/main/site/static/icon/slack.svg"
  - name: "Discord"
    target: "https://discord.gg/coder"
    icon: "https://raw.githubusercontent.com/coder/coder/main/site/static/icon/discord.svg"
  - name: "Foobar"
    target: "https://discord.gg/coder"
    icon: "/emojis/1f3e1.png"

@mtojek mtojek self-assigned this Jan 15, 2024
@mtojek mtojek marked this pull request as ready for review January 15, 2024 15:52
@mtojek mtojek merged commit f915bdf into main Jan 15, 2024
@mtojek mtojek deleted the 11611-custom-url branch January 15, 2024 15:56
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnstcn johnstcn johnstcn approved these changes

@BrunoQuaresma BrunoQuaresma Awaiting requested review from BrunoQuaresma

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

supportLinks icons do not read /icon/ directory or any icon URLs
2 participants
@mtojek @johnstcn