fix: Add redirect for OAuth from /login #1163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for a complete sign-up flow: 1. coder login https://dev.coder.com 2. Navigates to /cli-auth 3. Redirects to /login?redirect=%2Fcli-auth 4. User signs in with GitHub 5. User is redirected back to /cli-auth
Codecov Report
@@ Coverage Diff @@
## main #1163 +/- ##
==========================================
+ Coverage 57.76% 66.54% +8.78%
==========================================
Files 263 263
Lines 16427 16428 +1
Branches 156 156
==========================================
+ Hits 9489 10932 +1443
+ Misses 5907 4376 -1531
- Partials 1031 1120 +89
Continue to review full report at Codecov.
|
BrunoQuaresma
approved these changes
Apr 25, 2022
|
@coder/frontend if anyone else has opinions on anything here, I'm open to comments/adjustments after merge too! |
kylecarbs
added a commit
that referenced
this pull request
Jun 10, 2022
This allows for a complete sign-up flow: 1. coder login https://dev.coder.com 2. Navigates to /cli-auth 3. Redirects to /login?redirect=%2Fcli-auth 4. User signs in with GitHub 5. User is redirected back to /cli-auth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for a complete sign-up flow: