Skip to content

feat(cli/exp): add app testing to scaletest workspace-traffic #11633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 19, 2024
Merged

feat(cli/exp): add app testing to scaletest workspace-traffic #11633

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ef5cb9a
feat(cli/exp): add app testing to scaletest workspace-traffic
mafredri Jan 16, 2024
fd6b18d
split code into createWorkspaceAppConfig
mafredri Jan 19, 2024
02c14e6
reorganize eof check and return
mafredri Jan 19, 2024
20e93b9
revert rptyJSONMaxDataSize change, increased value caused a flake
mafredri Jan 19, 2024
f52b492
explain how context is used with websocket.NetConn
mafredri Jan 19, 2024
f6e399c
make read/write byte assertion more lax in test
mafredri Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
revert rptyJSONMaxDataSize change, increased value caused a flake
  • Loading branch information
@mafredri
mafredri committed Jan 19, 2024
commit 20e93b98ef5c297cc9b03e7d5ee003e99ba9ad57
6 changes: 3 additions & 3 deletions scaletest/workspacetraffic/conn.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@ const (
//
// failed to write frame: WebSocket closed: received close frame: status = StatusMessageTooBig and reason = "read limited at 32769 bytes"
//
// Since we can't control fragmentation/buffer sizes, we use a conservative
// value. Derived from 1024 * 9 * 3 = <28KB.
rptyJSONMaxDataSize = 1024 * 9
// Since we can't control fragmentation/buffer sizes, we keep it simple and
// match the conservative payload size used by agent/reconnectingpty (1024).
rptyJSONMaxDataSize = 1024
)

func connectRPTY(ctx context.Context, client *codersdk.Client, agentID, reconnect uuid.UUID, cmd string) (*countReadWriteCloser, error) {
Expand Down