Skip to content

feat: expose owner_name in coder_workspace resource #11639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jan 17, 2024
Merged

feat: expose owner_name in coder_workspace resource #11639

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
6653b24
Update go.mod
mtojek Jan 16, 2024
2b239ab
Proto changes
mtojek Jan 16, 2024
7fd0577
WIP
mtojek Jan 16, 2024
2defb89
make gen
mtojek Jan 16, 2024
06208e5
Fix TODO
mtojek Jan 16, 2024
e0d8551
UpdateUserProfile name
mtojek Jan 16, 2024
e3565e6
Patching frontend
mtojek Jan 16, 2024
e6c23aa
name not confidential
mtojek Jan 16, 2024
7df71de
find and replace
mtojek Jan 16, 2024
afced2a
Fix golden
mtojek Jan 16, 2024
8e6f929
Fix ts
mtojek Jan 16, 2024
97dfbcf
Merge branch 'main' into 9883-add-owner-to-workspace
mtojek Jan 17, 2024
4d8934d
bad linting
mtojek Jan 17, 2024
15367f0
Unit test
mtojek Jan 17, 2024
891705f
Validate real name
mtojek Jan 17, 2024
f3c0c42
Fix
mtojek Jan 17, 2024
d116566
Address PR comments
mtojek Jan 17, 2024
2bc609e
Fix strings.TrimSpace
mtojek Jan 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix strings.TrimSpace
  • Loading branch information
@mtojek
mtojek committed Jan 17, 2024
commit 2bc609e359a9af11342068061ff04eb391740ec7
3 changes: 1 addition & 2 deletions coderd/httpapi/name.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,7 @@ func UserRealNameValid(str string) error {
return xerrors.New("must be <= 128 characters")
}

trimmed := strings.TrimSpace(str)
if trimmed != str {
if strings.TrimSpace(str) != str {
return xerrors.New("must not have leading or trailing white spaces")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happened to catch my eye, whitespace is uncountable, so we drop s. Alt: whitespace characterS.

Suggested change
return xerrors.New("must not have leading or trailing white spaces")
return xerrors.New("must not have leading or trailing whitespace")

Not sure about having white space in whitespace, though. Both could be correct 😄.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#11667

}
return nil
Expand Down