refactor(site): refactor resource and agents #11647
Conversation
|
just a quick remark. We can dynamic create coder applications. So this makes it easy for us to expose multiple microservices from one workspace. In this particular case we have a workpspace with at least 9 extra buttons across multiple lines. Nevertheless I like the new layout |
|
@MrPeacockNLB can you share how it looks like? |
…tor-resources-data
| const showVSCode = | ||
| (agent.display_apps.includes("vscode") || | ||
| agent.display_apps.includes("vscode_insiders")) && | ||
| !hideVSCodeDesktopButton; |
There was a problem hiding this comment.
The display code in this file is fairly complicated - there is a lot of conditional logic and you must understand the difference between the various VS Code apps and the difference between agent.apps and agent.display_apps. I think we could really benefit from some tests here, and maybe a comment or two. We have some tests for very similar logic in the AgentRowPreview component that might be worth looking at. Open to storybook tests, too...I'm just not sure how one could describe the business logic adequately through those, but interactions might help out!
There was a problem hiding this comment.
This is true. Thx for sharing a good test example 🙏
There was a problem hiding this comment.
I'm not sure the best way to print the results of a "table style" test.. What do you think about this?
|
Weird glitch with GitHub – all of my pending review comments got published, even though I wasn't done reviewing yet. Still planning to go through the rest of the code! |
There was a problem hiding this comment.
Overall, I think this all looks really good! And again, sorry for the PR rejection – I trust you, and know you wouldn't let the code go through. I just kind of panicked, especially since I already had GitHub randomly change my review comments, even just for this PR specifically
|
@Parkreiner @Kira-Pilot I think I solved all the comments. Let me know if there is anything open. |
|
@Parkreiner Idk why but some of your comments were posted as "regular comments" so I was not able to reply or mark as resolved 😢 |
Before:
Now:
