Skip to content

feat(cli/ssh): allow multiple remote forwards and allow missing local file #11648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 19, 2024
Merged

feat(cli/ssh): allow multiple remote forwards and allow missing local file #11648

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d192887
feat(cli/ssh): allow multiple remote forwards
mafredri Jan 16, 2024
8ba3c82
make gen
mafredri Jan 16, 2024
f99f490
add test case for multiple socket forwards
mafredri Jan 19, 2024
da07f1d
ignore command error
mafredri Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
ignore command error
  • Loading branch information
@mafredri
mafredri committed Jan 19, 2024
commit da07f1d7d91962dd3b33ca3833b33e117dd252da
3 changes: 2 additions & 1 deletion cli/ssh_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -925,7 +925,8 @@ func TestSSH(t *testing.T) {
pty := ptytest.New(t).Attach(inv)
inv.Stderr = pty.Output()

clitest.Start(t, inv.WithContext(ctx))
w := clitest.StartWithWaiter(t, inv.WithContext(ctx))
defer w.Wait() // We don't care about any exit error (exit code 255: SSH connection ended unexpectedly).

// Since something was output, it should be safe to write input.
// This could show a prompt or "running startup scripts", so it's
Expand Down