fix: revert "detect JetBrains running on local ipv6 (#11653)" #11664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2d61d53.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11659
This reverts commit #11653
I think what's happening is that Linux allows two different things to bind to the same port if one binds to IPv4 and another binds to IPv6. However, in
coderdtestwe start a test server which binds to127.0.0.1:0, and then overwrite the accessURL tohttp://localhost:<port>.localhostis ambiguous, so when the HTTP client then tries to dial, it will first try the IPv6 local IP (::1) before it tries IPv4 (127.0.0.1). If we happen to hit a port conflict, we hit the echo server, which triggers the HTTP protocol error.