Skip to content

chore: experiment building dogfood image with nix #11680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Jan 31, 2024
Merged

chore: experiment building dogfood image with nix #11680

merged 25 commits into from
Jan 31, 2024

Conversation

matifali
Copy link
Member

@matifali matifali commented Jan 18, 2024 •
edited
Loading

This PR builds a new dogfood image with minimum tools but all required dependencies to build and test coder. This is available as codercom/oss-dogfood-nix:latest and as an option in our dogfood template.

Testing

  • make fmt
  • make gen
  • make lint
  • make build
  • make test
  • make test-postgres
  • make update-golden-files
  • gotestsum --junitfile="gotests.xml" -- -race ./...
  • ./scripts/develop.sh
  • pnpm test
  • pnpm playwright:test

Note

This doesn't change or break any existing behavior.

@matifali matifali marked this pull request as draft January 18, 2024 03:28
@matifali matifali changed the title chore: build dogfood image with nix experiment: build dogfood image with nix Jan 18, 2024
@matifali matifali changed the title experiment: build dogfood image with nix chore: experiments building dogfood image with nix Jan 18, 2024
@matifali matifali changed the title chore: experiments building dogfood image with nix chore: experiment building dogfood image with nix Jan 18, 2024
@matifali matifali marked this pull request as ready for review January 18, 2024 08:29
johnstcn
johnstcn reviewed Jan 18, 2024
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No harm to give this a shot! The main acceptance criterion here is that develop.sh runs the same in this image as in the main dogfood image, and that we can run e.g. make test-postgres.

mafredri
mafredri reviewed Jan 18, 2024
View reviewed changes
@matifali
Copy link
Member Author

@johnstcn Both of these work <3
There are some issues with running the ppm test as I am getting into glibc mismatch issues.

@github-actions github-actions bot added the stale This issue is like stale bread. label Jan 31, 2024
@matifali matifali requested a review from johnstcn January 31, 2024 13:23
@matifali matifali removed the stale This issue is like stale bread. label Jan 31, 2024
matifali
matifali commented Jan 31, 2024
View reviewed changes
johnstcn
johnstcn approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good approach. We have a fallback option in case of issues with the Nix image.

@matifali matifali enabled auto-merge (squash) January 31, 2024 13:51
@matifali matifali disabled auto-merge January 31, 2024 13:52
@mtojek mtojek self-requested a review January 31, 2024 14:01
mtojek
mtojek approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@matifali matifali enabled auto-merge (squash) January 31, 2024 14:21
@matifali matifali merged commit 215a9d1 into main Jan 31, 2024
@matifali matifali deleted the nix-dogfood branch January 31, 2024 14:27
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mafredri mafredri mafredri left review comments

@johnstcn johnstcn johnstcn approved these changes

@mtojek mtojek mtojek approved these changes

@kylecarbs kylecarbs Awaiting requested review from kylecarbs

@Emyrk Emyrk Awaiting requested review from Emyrk

Assignees

@matifali matifali

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matifali @mafredri @johnstcn @mtojek