feat(site): show version files diff based on active version #11686
Conversation
| @@ -236,6 +237,38 @@ export const resources = (versionId: string) => { | |||
| }; | |||
| }; | |||
|
|
|||
| export const templateFiles = (fileId: string) => { | |||
| return { | |||
| queryKey: ["templateFiles", fileId], | |||
There was a problem hiding this comment.
Do you think it makes sense to update the query keys for templateFiles and previousTemplateVersion to start with something like "template"? Feels like it'd be a good way to make sure we have an easy way to invalidate any template queries down the line
There was a problem hiding this comment.
If we had the template ID or name I would say yes, but since they are "isolated" I'm ok to keep the current names until we see value in changing them.
| tab, | ||
| }) => { | ||
| const filenames = Object.keys(currentFiles); | ||
| const selectedFilename = filenames[Number(tab.value)]; | ||
| const currentFile = currentFiles[selectedFilename]; | ||
| const previousFile = previousFiles && previousFiles[selectedFilename]; | ||
| const previousFile = baseFiles && baseFiles[selectedFilename]; |
There was a problem hiding this comment.
Not a call out to your code, but there's some weird behavior here (based around undefined) that I'm guessing that the compiler isn't complaining about right now, because we don't have it set strictly enough.
Here's a TypeScript snippet with the compiler tightened up. I'm going to be bringing this up at the Frontend Variety later today
There was a problem hiding this comment.
Yes, I think we should set this rule as true: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-1.html#checked-indexed-accesses---nouncheckedindexedaccess
Close #11295