Skip to content

chore: add a story for WorkspaceOutdatedTooltip #11695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Jan 18, 2024

Screenshot 2024-01-18 at 4 19 18 PM

Can be improved later when we figure out the whole Storybook/Chromatic interactions thing, but does the whole data mocking thing that the cool kids are on these days

onUpdateVersion: action("onUpdateVersion"),
templateName: MockTemplate.display_name,
latestVersionId: MockTemplateVersion.id,
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of adding a new decorator you can use parameters like:

parameters: {
  queries: [
    {
      key: ["templateVersion", MockTemplateVersion.id],
      data: MockTemplateVersion 
    }
  ]
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh! neat! the health page example I looked at used useQueryClient, but this seems nice

Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment.

@aslilac aslilac merged commit 75d70a9 into main Jan 19, 2024
@aslilac aslilac deleted the outdated-tooltip-story branch January 19, 2024 18:41
@github-actions github-actions bot locked and limited conversation to collaborators Jan 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants