fix: display error when fetching OAuth2 provider apps #11713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
Parkreiner
approved these changes
Jan 22, 2024
| @@ -28,12 +29,14 @@ type OAuth2AppsSettingsProps = { | |||
| apps?: TypesGen.OAuth2ProviderApp[]; | |||
| isEntitled: boolean; | |||
| isLoading: boolean; | |||
| error?: unknown; | |||
There was a problem hiding this comment.
Should this be optional? Feels like making a dev always pass a value in (even if it's hopefully undefined 99% of the time) would help make sure we don't forget our errors as the code gets updated over time
There was a problem hiding this comment.
Good point, I just assumed it could be undefined from React Query but I did not actually check. 😛
There was a problem hiding this comment.
Ah I see, it can be null but not undefined. Fixing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was pulled out of #11609. I am trying to break out parts of that PR so we can review and merge it more easily.