Skip to content

feat: add "updated" search param to workspaces #11714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 23, 2024

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Jan 19, 2024

fixes #11325

Can now search for updated workspaces in the search query

@Emyrk Emyrk requested a review from sreya January 19, 2024 20:58
Copy link
Collaborator

@sreya sreya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand why the parameter is named differently at all parts of the stack. The frontend is named outdated -- which makes the most sense to me for the name. But the backend name is updated and then the database parameter is update_active. Why not have them consistent?

@Emyrk
Copy link
Member Author

Emyrk commented Jan 22, 2024

I'm not sure I understand why the parameter is named differently at all parts of the stack. The frontend is named outdated -- which makes the most sense to me for the name. But the backend name is updated and then the database parameter is update_active. Why not have them consistent?

There is only two names from a code POV.

I am using UsingActive on the database because that is physically the database column we are checking. It felt odd to put "updated" there because that word doesn't feel semantically correct.

For the api I used the word updated since that is the phrasing of the original ticket. And we use the language "Update" on the workspaces page when a workspace is out-of-date. So the FE tends to use updated as the language.

"Outdated" is just the helper text for the quick search query list. I felt this would be more commonly used that searching for all updated workspaces. And the ticket was requesting this as the feature. So that is the one I made as the quick link.

Screenshot from 2024-01-22 14-45-29

If you click it though, the language is "updated".

Screenshot from 2024-01-22 14-46-31

@Emyrk Emyrk requested a review from sreya January 22, 2024 20:47
Copy link
Collaborator

@sreya sreya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I think outdated makes more sense as the query param but ultimately up to you.

@Emyrk
Copy link
Member Author

Emyrk commented Jan 22, 2024

Personally I think outdated makes more sense as the query param but ultimately up to you.

I will use outdated as the query param 👍

@Emyrk Emyrk force-pushed the stevenmasley/active_template_filter branch from ac2be0e to ae0179f Compare January 23, 2024 16:33
@Emyrk Emyrk merged commit d6ba0df into main Jan 23, 2024
@Emyrk Emyrk deleted the stevenmasley/active_template_filter branch January 23, 2024 17:52
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Show workspaces using out-of-date template versions
2 participants