Skip to content

fix: make yarn from nix flake use the right version of node #11716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

code-asher
Copy link
Member

@code-asher code-asher commented Jan 19, 2024

Otherwise if for example you try to run yarn storybook it complains that the version of Node is wrong.

pnpm storybook works fine and maybe that is what we should actually use, but as long as we have yarn installed might as well make use the right thing.

Otherwise if for example you try to run `yarn storybook` it complains
that the version of Node is wrong.

`pnpm storybook` works fine and maybe that is what we should use, but as
long as we have yarn installed might as well make it do the right thing.
@code-asher code-asher marked this pull request as ready for review January 19, 2024 21:34
@code-asher code-asher requested a review from mtojek January 19, 2024 21:36
@code-asher code-asher changed the title chore: make yarn use the right version of node fix: make yarn from nix flake use the right version of node Jan 19, 2024
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this change! I focused on pnpm, but as long as we can make yarn run successfully that works too.

@code-asher code-asher merged commit fa99f6a into main Jan 19, 2024
@code-asher code-asher deleted the asher/nix-yarn-nodejs-version branch January 19, 2024 21:59
@github-actions github-actions bot locked and limited conversation to collaborators Jan 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants