Skip to content

feat: add endpoints to oauth2 provider apps response #11718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

code-asher
Copy link
Member

@code-asher code-asher commented Jan 19, 2024

These will show up when configuring the application along with the client ID and everything else. Should make it easier to use the application, otherwise you will have to go look up the URLs in the docs (which are not yet written).

Mostly extracted from #11609 to make that PR smaller, except I added a list to display them in the frontend as well.

@code-asher code-asher force-pushed the asher/oauth-app-endpoints branch from 8d51623 to 1502265 Compare January 19, 2024 22:36
@code-asher code-asher changed the title feat: add endpoints to oauth2 provider applications feat: add endpoints to oauth2 provider apps response Jan 19, 2024
@code-asher code-asher force-pushed the asher/oauth-app-endpoints branch 2 times, most recently from 7c994d0 to 9ef2971 Compare January 19, 2024 22:43
These will show up when configuring the application along with the
client ID and everything else.  Should make it easier to configure the
application, otherwise you will have to go look up the URLs in the
docs (which are not yet written).

Co-authored-by: Steven Masley <stevenmasley@gmail.com>
@code-asher code-asher force-pushed the asher/oauth-app-endpoints branch from 9ef2971 to 277269f Compare January 19, 2024 22:44
@code-asher code-asher marked this pull request as ready for review January 19, 2024 22:55
Copy link
Member

@Parkreiner Parkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the stories, and the client-side stuff looks good! If there aren't any issues with the Go code, the PR should be good to approve

}}
/>
</CopyableValue>
<dl css={styles.dataList}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big fan of the definition list usage

Copy link
Member

@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you screencap what this looks like?

Copy link
Member

@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Go looks fine though 👍

@code-asher
Copy link
Member Author

Can you screencap what this looks like?

It can be viewed and messed around with here on Chromatic: https://624de63c6aacee003aa84340-yiqrjtuxwr.chromatic.com/?path=/story/pages-deploysettingspage-editoauth2apppageview--default

@code-asher code-asher merged commit 3014777 into main Jan 22, 2024
@code-asher code-asher deleted the asher/oauth-app-endpoints branch January 22, 2024 22:25
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants