Skip to content

fix: Display proper access URL on server start #1172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2022
Merged

fix: Display proper access URL on server start #1172

merged 1 commit into from
Apr 25, 2022

Conversation

kylecarbs
Copy link
Member

Fixes #1170.

@kylecarbs kylecarbs requested a review from bpmct April 25, 2022 22:49
@kylecarbs kylecarbs self-assigned this Apr 25, 2022
@codecov
Copy link

codecov bot commented Apr 25, 2022 •
edited
Loading

Codecov Report

Merging #1172 (2498e11) into main (947e8f9) will decrease coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1172      +/-   ##
==========================================
- Coverage   66.51%   66.33%   -0.19%     
==========================================
  Files         263      263              
  Lines       16573    16575       +2     
  Branches      156      156              
==========================================
- Hits        11024    10995      -29     
- Misses       4419     4441      +22     
- Partials     1130     1139       +9
Flag Coverage Δ
unittest-go-macos-latest 53.65% <80.00%> (-0.12%) ⬇️
unittest-go-postgres- 65.69% <100.00%> (-0.11%) ⬇️
unittest-go-ubuntu-latest 56.22% <80.00%> (-0.09%) ⬇️
unittest-go-windows-2022 53.24% <80.00%> (-0.05%) ⬇️
unittest-js 67.45% <ø> (ø)
Impacted Files Coverage Δ
cli/server.go 58.98% <100.00%> (ø)
provisionerd/provisionerd.go 77.10% <100.00%> (-0.47%) ⬇️
cli/cliui/agent.go 77.19% <0.00%> (-5.27%) ⬇️
coderd/workspaceagents.go 58.92% <0.00%> (-4.29%) ⬇️
coderd/turnconn/turnconn.go 81.91% <0.00%> (-3.20%) ⬇️
agent/agent.go 65.70% <0.00%> (-2.80%) ⬇️
provisioner/echo/serve.go 54.40% <0.00%> (-2.40%) ⬇️
codersdk/workspaceagents.go 51.86% <0.00%> (-1.50%) ⬇️
peerbroker/listen.go 87.39% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 947e8f9...2498e11. Read the comment docs.

@bpmct bpmct enabled auto-merge (squash) April 25, 2022 22:53
@bpmct bpmct merged commit 877854a into main Apr 25, 2022
@bpmct bpmct deleted the fixdisplay branch April 25, 2022 23:30
kylecarbs added a commit that referenced this pull request Jun 10, 2022
@kylecarbs
fix: Display proper access URL on server start (#1172)
3830ca6 
Fixes #1170.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpmct bpmct bpmct approved these changes

Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: coderd does not respect access URL for coder login helper on start
2 participants
@kylecarbs @bpmct