Skip to content

feat: add user-level parameter autofill #11731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Jan 30, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
site: use distinct coderd pprof port
  • Loading branch information
ammario committed Jan 21, 2024
commit 93deee5e4417283059f8d975890080c13806d0d4
5 changes: 4 additions & 1 deletion site/e2e/constants.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
// Default port from the server
export const defaultPort = 3000;
export const prometheusPort = 2114;
export const pprofPort = 6061;

// Use alternate ports in case we're running in a Coder Workspace.
export const agentPProfPort = 6061;
export const coderdPProfPort = 6062;

// Credentials for the first user
export const username = "admin";
Expand Down
4 changes: 2 additions & 2 deletions site/e2e/helpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import {
Resource,
RichParameter,
} from "./provisionerGenerated";
import { prometheusPort, pprofPort } from "./constants";
import { prometheusPort, agentPProfPort } from "./constants";
import { port } from "./playwright.config";
import * as ssh from "ssh2";
import { Duplex } from "stream";
Expand Down Expand Up @@ -306,7 +306,7 @@ export const startAgentWithCommand = async (
...process.env,
CODER_AGENT_URL: "http://localhost:" + port,
CODER_AGENT_TOKEN: token,
CODER_AGENT_PPROF_ADDRESS: "127.0.0.1:" + pprofPort,
CODER_AGENT_PPROF_ADDRESS: "127.0.0.1:" + agentPProfPort,
CODER_AGENT_PROMETHEUS_ADDRESS: "127.0.0.1:" + prometheusPort,
},
});
Expand Down
3 changes: 2 additions & 1 deletion site/e2e/playwright.config.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { defineConfig } from "@playwright/test";
import path from "path";
import { defaultPort, gitAuth } from "./constants";
import { defaultPort, coderdPProfPort, gitAuth } from "./constants";

export const port = process.env.CODER_E2E_PORT
? Number(process.env.CODER_E2E_PORT)
Expand Down Expand Up @@ -103,6 +103,7 @@ export default defineConfig({
gitAuth.webPort,
gitAuth.validatePath,
),
CODER_PPROF_ADDRESS: "127.0.0.1:" + coderdPProfPort,
},
reuseExistingServer: false,
},
Expand Down
2 changes: 1 addition & 1 deletion site/e2e/reporter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ const filteredServerLogLines = (chunk: string): string[] =>

const exportDebugPprof = async (outputFile: string) => {
const response = await axios.get(
"http://127.0.0.1:6060/debug/pprof/goroutine?debug=1",
"http://127.0.0.1:6062/debug/pprof/goroutine?debug=1",
);
if (response.status !== 200) {
throw new Error(`Error: Received status code ${response.status}`);
Expand Down