Skip to content

feat(scaletest/templates): add support for concurrent scenarios #11753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jan 30, 2024
Merged

feat(scaletest/templates): add support for concurrent scenarios #11753

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
036aa8d
feat(scaletest/templates): add support for concurrent scenarios
mafredri Jan 22, 2024
17605a7
bump resources to the max
mafredri Jan 22, 2024
806c73f
remove limits entirely
mafredri Jan 22, 2024
96100c0
allow more flexibility in cleanup
mafredri Jan 23, 2024
569cfc1
allow staggered start
mafredri Jan 24, 2024
d0fbd2c
improve cleanup
mafredri Jan 24, 2024
3141efe
fix dashboard screengrabs location
mafredri Jan 24, 2024
f58bf41
add more cleanup cases
mafredri Jan 24, 2024
4754f2f
fix updating of static time
mafredri Jan 24, 2024
1236b93
echo
mafredri Jan 24, 2024
724e1c5
add skip create workspaces option
mafredri Jan 25, 2024
916c74d
fix start time regen
mafredri Jan 25, 2024
aeb9c52
add retry
mafredri Jan 29, 2024
60df607
fix undetected error exit code
mafredri Jan 29, 2024
23d936e
minor cleanup
mafredri Jan 30, 2024
82b95d4
fix typo
mafredri Jan 30, 2024
74812f6
stagger delay mins
mafredri Jan 30, 2024
21bc64b
add note about prom http port name
mafredri Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add retry
  • Loading branch information
@mafredri
mafredri committed Jan 29, 2024
commit aeb9c529107271292dbe836ff84fb64084149456
4 changes: 4 additions & 0 deletions scaletest/templates/scaletest-runner/scripts/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,11 @@ set_status Running

start_phase "Creating workspaces"
if [[ ${SCALETEST_PARAM_SKIP_CREATE_WORKSPACES} == 0 ]]; then
# Note that we allow up to 5 failures to bring up the workspace, since
# we're creating a lot of workspaces at once and some of them may fail
# due to network issues or other transient errors.
coder exp scaletest create-workspaces \
--retry 5 \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious if this must be ignored&retried, maybe we should identify and fix problems in a different way, even provisioning workspaces slower?

Anyway, consider it to be a side thought.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would have to ensure terraform registry is cached locally, once we know workspace builds don't use any external networking, we could potentially disable the retry, if we want. 👍🏻

--count "${SCALETEST_PARAM_NUM_WORKSPACES}" \
--template "${SCALETEST_PARAM_TEMPLATE}" \
--concurrency "${SCALETEST_PARAM_CREATE_CONCURRENCY}" \
Expand Down