refactor(site): refactor external auth component #11758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r-external-auth-api
Parkreiner
approved these changes
Jan 23, 2024
| jest | ||
| .spyOn(API, "getTemplateVersionExternalAuth") | ||
| .mockResolvedValueOnce([MockTemplateVersionExternalAuthGithub]); | ||
|
|
||
| renderCreateWorkspacePage(); | ||
| await waitForLoaderToBeRemoved(); | ||
|
|
||
| const nameField = await screen.findByLabelText(nameLabelText); | ||
|
|
||
| // have to use fireEvent b/c userEvent isn't cleaning up properly between tests |
There was a problem hiding this comment.
I know that we have the test simplified down now, so this comment wouldn't even be relevant anymore, but do you know if we ever figured out the userEvent issue? This is the first I've heard of it not cleaning up properly, but some digging made it sounds like it was a bug with the library
There was a problem hiding this comment.
I don't know, to be honest, I just removed it from here because we don't need to fill in the name input to see the error.
|
Related to #11742 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recommended improvements:
Before:
Now:
