chore: refactor Appearance to an interface callable by AGPL code #11769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 23, 2024
This was referenced Jan 23, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @spikecurtis and the rest of your teammates on |
This was referenced Jan 23, 2024
5c875b2 to
f168e58
Compare
d63b387 to
5ad6f3f
Compare
code-asher
reviewed
Jan 24, 2024
f168e58 to
faa1f29
Compare
5ad6f3f to
4fc8623
Compare
faa1f29 to
e980510
Compare
4fc8623 to
cdec5e1
Compare
code-asher
approved these changes
Jan 25, 2024
e980510 to
eaabdb7
Compare
cdec5e1 to
79bee1c
Compare
eaabdb7 to
6a70ddf
Compare
79bee1c to
529250f
Compare
6a70ddf to
c980d65
Compare
529250f to
25063cb
Compare
This was referenced Jan 26, 2024
c980d65 to
38f23ea
Compare
25063cb to
06d2b3d
Compare
06d2b3d to
810bb6e
Compare
Merge activity
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new Agent API needs an interface for ServiceBanners, so this PR creates it and refactors the AGPL and Enterprise code to achieve it.
Before we depended on the fact that the HTTP endpoint was missing to serve an empty ServiceBanner on AGPL deployments, but that won't work with dRPC, so we need a real interface to call.