Skip to content

feat(site): generates unique workspace names by default #11772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2024
Merged

feat(site): generates unique workspace names by default #11772

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf3ee27
feat(site): generates unique workspace names by default
BrunoQuaresma Jan 23, 2024
8b9c28f
fix default name getting regenerated
BrunoQuaresma Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix default name getting regenerated
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed Jan 23, 2024
commit 8b9c28f0085275bc052a2a141449717ea7bf886f
21 changes: 10 additions & 11 deletions site/src/pages/CreateWorkspacePage/CreateWorkspacePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { type FC, useCallback, useState, useEffect } from "react";
import { type FC, useCallback, useState, useEffect, useMemo } from "react";
import { Helmet } from "react-helmet-async";
import { useNavigate, useParams, useSearchParams } from "react-router-dom";
import { useMutation, useQuery, useQueryClient } from "react-query";
Expand Down Expand Up @@ -44,7 +44,15 @@ const CreateWorkspacePage: FC = () => {
const defaultBuildParameters = getDefaultBuildParameters(searchParams);
const mode = getWorkspaceMode(searchParams);
const customVersionId = searchParams.get("version") ?? undefined;
const defaultName = getDefaultName(mode, searchParams);

const defaultName = useMemo(() => {
const paramsName = searchParams.get("name");
if (mode === "duplicate" && paramsName) {
return `${paramsName}-copy`;
}

return paramsName ?? generateUniqueName();
}, [mode, searchParams]);

const queryClient = useQueryClient();
const autoCreateWorkspaceMutation = useMutation(
Expand Down Expand Up @@ -242,12 +250,3 @@ function getWorkspaceMode(params: URLSearchParams): CreateWorkspaceMode {

return "form";
}

function getDefaultName(mode: CreateWorkspaceMode, params: URLSearchParams) {
const paramsName = params.get("name");
if (mode === "duplicate" && paramsName) {
return `${paramsName}-copy`;
}

return paramsName ?? generateUniqueName();
}