Skip to content

feat: add oauth2 codes and tokens to database #11779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

feat: add oauth2 codes and tokens to database #11779

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d54e56a
Add OAuth2 provider codes and tokens to database
code-asher Jan 9, 2024
7b118ac
Check indexes in dbmem
code-asher Jan 24, 2024
b0df965
minor dbauthz changes
Emyrk Jan 24, 2024
cc366f6
use model struct over rbac.ResourceXX
Emyrk Jan 24, 2024
be2ad57
Rename token hashed_secret to refresh_hash
code-asher Jan 24, 2024
8368548
Bump migration number
code-asher Jan 24, 2024
29a9e26
Format oauth2.sql
code-asher Jan 24, 2024
c15f851
fixup! Rename token hashed_secret to refresh_hash
code-asher Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
minor dbauthz changes
  • Loading branch information
@Emyrk
Emyrk committed Jan 24, 2024
commit b0df9650f8360611f1d0a1ea5f7fc85ed34f2669
4 changes: 2 additions & 2 deletions coderd/database/dbauthz/dbauthz.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -826,7 +826,7 @@ func (q *querier) DeleteOAuth2ProviderAppCodeByID(ctx context.Context, id uuid.U
if err != nil {
return err
}
if err := q.authorizeContext(ctx, rbac.ActionDelete, rbac.ResourceOAuth2ProviderAppCodeToken.WithOwner(code.UserID.String())); err != nil {
if err := q.authorizeContext(ctx, rbac.ActionDelete, code); err != nil {
return err
}
return q.db.DeleteOAuth2ProviderAppCodeByID(ctx, id)
Expand Down Expand Up @@ -1222,7 +1222,7 @@ func (q *querier) GetOAuth2ProviderApps(ctx context.Context) ([]database.OAuth2P
}

func (q *querier) GetOAuth2ProviderAppsByUserID(ctx context.Context, userID uuid.UUID) ([]database.GetOAuth2ProviderAppsByUserIDRow, error) {
// These two authz checks make sure the caller can read all their own tokens.
// This authz check is to make sure the caller can read all their own tokens.
if err := q.authorizeContext(ctx, rbac.ActionRead,
rbac.ResourceOAuth2ProviderAppCodeToken.WithOwner(userID.String())); err != nil {
return []database.GetOAuth2ProviderAppsByUserIDRow{}, err
Expand Down