feat: build & release cross-platform Docker images #1178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpmct
commented
Apr 25, 2022
Codecov Report
@@ Coverage Diff @@
## main #1178 +/- ##
==========================================
+ Coverage 66.97% 67.02% +0.04%
==========================================
Files 288 285 -3
Lines 18857 19022 +165
Branches 241 241
==========================================
+ Hits 12630 12750 +120
- Misses 4939 4951 +12
- Partials 1288 1321 +33
Continue to review full report at Codecov.
|
This was referenced May 5, 2022
bpmct
commented
May 11, 2022
Comment on lines
+26
to
+28
| registry: ghcr.io | ||
| username: ${{ github.repository_owner }} | ||
| password: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Actually, we need a PAT here. Will probably need help from an org admin to get this
from: https://carlosbecker.com/posts/multi-platform-docker-images-goreleaser-gh-actions/
We need to login into the GitHub Container Registry with a Personal Access Token (PAT), since the default GITHUB_TOKEN does not have enough permissions
|
This PR is ready for review, but I need help:
|
4 tasks
kylecarbs
reviewed
May 11, 2022
kylecarbs
approved these changes
May 12, 2022
kylecarbs
pushed a commit
that referenced
this pull request
Jun 10, 2022
* feat: add dockerfile and docker-compose * build docker images on release * add Docker dependencies to release.yaml * remove docker compose for now * fix license mismatch * add docker-compose * rename volume * add WF dispatch for debugging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will build cross-platform docker images for each release. Contributions are welcome!
Subtasks
create docker-composewill leave this for the DocsFixes #1177