feat(cli): add favorite/unfavorite commands #11793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
commented
Jan 24, 2024
johnstcn
commented
Jan 24, 2024
mtojek
approved these changes
Jan 24, 2024
|
|
||
| buf.Reset() | ||
|
|
||
| inv, root = clitest.New(t, "unfavorite", ws.Workspace.Name) |
There was a problem hiding this comment.
What will happen if a user marks their workspace as "favorite" twice? Is it relevant?
There was a problem hiding this comment.
Nothing interesting really will happen. It'll get updated again, which is essentially a no-op. We could check if the workspace is already favorited, but the overhead probably isn't worth the effort.
6c20099 to
0cc97bb
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7912
Depends on #11791
Adds CLI commands allowing users to add/remove workspaces from their favorites.