Skip to content

fix: Increase default provisioner daemons to 3 #1180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2022
Merged

fix: Increase default provisioner daemons to 3 #1180

merged 1 commit into from
Apr 26, 2022

Conversation

kylecarbs
Copy link
Member

It's odd to only build one workspace at a time as a default.

It's odd to only build one workspace at a time as a default.
@kylecarbs kylecarbs requested a review from bpmct April 26, 2022 01:30
@kylecarbs kylecarbs self-assigned this Apr 26, 2022
@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #1180 (a52dcc5) into main (744a00a) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1180      +/-   ##
==========================================
+ Coverage   66.16%   66.28%   +0.11%     
==========================================
  Files         257      263       +6     
  Lines       16394    16615     +221     
  Branches      156      156              
==========================================
+ Hits        10847    11013     +166     
- Misses       4417     4460      +43     
- Partials     1130     1142      +12     
Flag Coverage Δ
unittest-go-macos-latest 53.58% <100.00%> (?)
unittest-go-postgres- 65.55% <100.00%> (+0.04%) ⬆️
unittest-go-ubuntu-latest 56.17% <100.00%> (-0.07%) ⬇️
unittest-go-windows-2022 53.23% <100.00%> (?)
unittest-js 67.45% <ø> (ø)
Impacted Files Coverage Δ
cli/server.go 58.98% <100.00%> (ø)
peerbroker/dial.go 77.04% <0.00%> (-6.56%) ⬇️
peerbroker/proxy.go 58.72% <0.00%> (-3.49%) ⬇️
coderd/workspaceagents.go 55.59% <0.00%> (-2.56%) ⬇️
provisioner/echo/serve.go 56.80% <0.00%> (-2.41%) ⬇️
peer/channel.go 83.23% <0.00%> (-0.58%) ⬇️
provisioner/terraform/provision.go 70.96% <0.00%> (-0.44%) ⬇️
cli/ssh_windows.go 0.00% <0.00%> (ø)
cli/cliui/cliui_darwin.go 0.00% <0.00%> (ø)
pty/start_windows.go 66.95% <0.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 744a00a...a52dcc5. Read the comment docs.

@bpmct bpmct merged commit f9ce54a into main Apr 26, 2022
@bpmct bpmct deleted the provisioners branch April 26, 2022 12:19
kylecarbs added a commit that referenced this pull request Jun 10, 2022
It's odd to only build one workspace at a time as a default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants