Skip to content

refactor(site): improve parameters field #11802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 26, 2024
Merged

refactor(site): improve parameters field #11802

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e97824a
refactor(site): improve parameters fields
BrunoQuaresma Jan 24, 2024
49fab93
Fix error validation
BrunoQuaresma Jan 24, 2024
ae1890d
Use pill instead of text
BrunoQuaresma Jan 26, 2024
0a5e6b7
Fix when showing parameters
BrunoQuaresma Jan 26, 2024
6c2b035
Remove immutable parameters section from workspace parameters form
BrunoQuaresma Jan 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix when showing parameters
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed Jan 26, 2024
commit 0a5e6b75c14775d668d085a7b46502b55cb0373d
3 changes: 3 additions & 0 deletions site/src/components/RichParameterInput/RichParameterInput.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,10 @@ export const WithError: Story = {
name: "number_parameter",
type: "number",
description: "Numeric parameter",
default_value: "",
}),
error: true,
helperText: "Number must be greater than 5",
},
};

Expand Down
2 changes: 1 addition & 1 deletion site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ export const CreateWorkspacePageView: FC<CreateWorkspacePageViewProps> = ({
</FormFields>
</FormSection>

{parameters && (
{parameters.length > 0 && (
<FormSection
title="Parameters"
description="These are the settings used by your template. Please note that immutable parameters cannot be modified once the workspace is created."
Expand Down