Skip to content

fix: rewrite url to agent ip in single tailnet #11810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 1, 2024
Merged

fix: rewrite url to agent ip in single tailnet #11810

merged 3 commits into from
Feb 1, 2024

Conversation

coadler
Copy link
Contributor

@coadler coadler commented Jan 24, 2024

This restores previous behavior of being able to cache connections
across agents in single tailnet.

@coadler
Copy link
Contributor Author

coadler commented Jan 24, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @coadler and the rest of your teammates on Graphite Graphite

@coadler coadler force-pushed the colin/fixrewriteurltoagentipinsingletailnet branch from b7ba1c9 to 3fd1d32 Compare January 24, 2024 19:52
@coadler coadler mentioned this pull request Jan 24, 2024
Closed
spikecurtis
spikecurtis approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@spikecurtis spikecurtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine to go in, but an integration/regression test with 2 workspaces is also needed, although that can be in a separate PR if you like.

@coadler coadler force-pushed the colin/fixrewriteurltoagentipinsingletailnet branch from 3fd1d32 to 6d7722e Compare February 1, 2024 00:03
@coadler
fix: rewrite url to agent ip in single tailnet
f766129 
This restores previous behavior of being able to cache connections
across agents in single tailnet.
@coadler
add integration test
698e697
@coadler
add comment on idle conn tuning
682467e
@coadler coadler force-pushed the colin/fixrewriteurltoagentipinsingletailnet branch from 6d7722e to 682467e Compare February 1, 2024 05:25
@coadler coadler merged commit 3ace798 into main Feb 1, 2024
@coadler coadler deleted the colin/fixrewriteurltoagentipinsingletailnet branch February 1, 2024 06:25
@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@spikecurtis spikecurtis spikecurtis approved these changes

@deansheather deansheather Awaiting requested review from deansheather

Assignees

@coadler coadler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coadler @spikecurtis