feat(cli/exp): extend scaletest create-workspaces with --retry option #11825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
commented
Jan 25, 2024
| TemplateVersionID: req.TemplateVersionID, | ||
| }) | ||
| if err != nil { | ||
| return xerrors.Errorf("create workspace build: %w", err) |
There was a problem hiding this comment.
Review: We could simply retry here, but I think it's unlikely another attempt will work if we can't create builds at all.
johnstcn
approved these changes
Jan 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
--retry Noption tocoder exp create-workspacesthat attempts to create a new start build if the previous one fails up to N times.Part of #11801