Skip to content

fix: always attempt external auth refresh when fetching (#11762) #11830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2024
Merged

fix: always attempt external auth refresh when fetching (#11762) #11830

merged 1 commit into from
Jan 29, 2024
+129 −80

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Jan 26, 2024

  • fix: always attempt external auth refresh when fetching
  • refactor validate to check expiry when considering "valid"

Original: #11762
Revert: 79568bf

Reported error

Using github as login.

{"message":"Internal error fetching authenticated Github user organizations.","detail":"GET https://api.github.com/user/memberships/orgs?per_page=100\u0026state=active: 401 Bad credentials []"}

I cannot reproduce this, nor do I see how this commit affects listing github user organizations.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 26, 2024 •
edited
Loading

✔️ PR 11830 Updated successfully.
🚀 Access the credentials here.

cc: @Emyrk

@Emyrk Emyrk marked this pull request as ready for review January 26, 2024 16:16
@Emyrk
fix: always attempt external auth refresh when fetching (#11762)
c872363 
* fix: always attempt external auth refresh when fetching
* refactor validate to check expiry when considering "valid"
@Emyrk Emyrk force-pushed the stevenmasley/external_auth_refresh_2 branch from 5b0d243 to c872363 Compare January 26, 2024 16:39
@Emyrk
Copy link
Member Author

Emyrk commented Jan 29, 2024

No 401s detected (as originally reported) since this has been on dogfood (Jan 26)

Screenshot from 2024-01-29 08-51-08

johnstcn
johnstcn approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dogfood was left running with this commit over the weekend and we were not able to reproduce the issue. I don't believe this commit was related to the issues we saw.

@Emyrk Emyrk merged commit d66e6e7 into main Jan 29, 2024
@Emyrk Emyrk deleted the stevenmasley/external_auth_refresh_2 branch January 29, 2024 14:55
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnstcn johnstcn johnstcn approved these changes

Assignees

@Emyrk Emyrk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Emyrk @johnstcn