chore(dogfood): replace repo_dir with base_repo_dir in git-clone module
#11835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` module After coder/modules#124, the `git-clone` module automatically appends and creates the path with the repo name, so we need to change the `path` input to specify the `repo_base_dir`. The `repo_dir` must still be passed to `code-server` and `jetbrains-gateway` modules and to set the `dir` field of `coder_agent`
repo_dir with base_repo_dir in `git-clone…repo_dir with base_repo_dir in git-clone module
mafredri
approved these changes
Jan 26, 2024
Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After coder/modules#124, the
git-clonemodule automatically appends and creates the path with the repo name, so we need to change thepathinput to specify therepo_base_dir.The
repo_dirmust still be passed tocode-serverandjetbrains-gatewaymodules and to set thedirfield ofcoder_agentDepends on coder/modules#132