feat: support template bundles as zip archives #11839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
approved these changes
Jan 31, 2024
Comment on lines
+189
to
+191
| case "": // no format? no conversion | ||
| rw.Header().Set("Content-Type", file.Mimetype) | ||
| _, _ = rw.Write(file.Data) |
There was a problem hiding this comment.
Maybe no harm to allow explicitly setting ContentTypeTar?
There was a problem hiding this comment.
I thought about it, but it would be another place to adjust if we decide to natively support other formats.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #11687
This PR implements format conversion in coderd API to support templates submitted as .zip files. I know that we can store different template formats in the database, but I decided to keep template format consistent across all files including the already submitted ones.
Once this PR is merged, users should be able to
POST /fileswith .zip content, and fetch .tar files converted to .zip on-the-fly usingGET /files/<file_id>?format=zip.