fix(coderd/rbac): do not cache context cancellation errors #11840
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should hopefully un-break #11800
#7439 added global caching of RBAC results.
Calls are cached based on
hash(subject, object, action)
.We often use
dbauthz.AsSystemRestricted
to handle "internal" authz calls, and these are often repeated with similar arguments and are likely to get cached.So a transient error doing an authz check on a system function will be cached for up to a minute.
I'm just starting off with excluding
context.Canceled
but there's likely a whole suite of different errors we want to also exclude from the global cache.