Skip to content

refactor: remove the user name #1185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 26, 2022
Merged

refactor: remove the user name #1185

merged 2 commits into from
Apr 26, 2022

Conversation

BrunoQuaresma
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma self-assigned this Apr 26, 2022
@BrunoQuaresma BrunoQuaresma requested a review from a team as a code owner April 26, 2022 17:46
@codecov
Copy link

codecov bot commented Apr 26, 2022 •
edited
Loading

Codecov Report

Merging #1185 (122281f) into main (441ffd6) will increase coverage by 9.22%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1185      +/-   ##
==========================================
+ Coverage   57.06%   66.28%   +9.22%     
==========================================
  Files         257      263       +6     
  Lines       16441    16662     +221     
  Branches      156      156              
==========================================
+ Hits         9382    11045    +1663     
+ Misses       6012     4469    -1543     
- Partials     1047     1148     +101
Flag Coverage Δ
unittest-go-macos-latest 53.60% <ø> (?)
unittest-go-postgres- 65.59% <ø> (?)
unittest-go-ubuntu-latest 56.15% <ø> (+0.05%) ⬆️
unittest-go-windows-2022 53.17% <ø> (?)
unittest-js 67.45% <ø> (ø)
Impacted Files Coverage Δ
.../PreferencesAccountForm/PreferencesAccountForm.tsx 100.00% <ø> (ø)
...pages/PreferencesPages/AccountPage/AccountPage.tsx 89.47% <ø> (ø)
site/src/testHelpers/entities.ts 100.00% <ø> (ø)
agent/usershell/usershell_windows.go 83.33% <0.00%> (ø)
pty/start_windows.go 66.95% <0.00%> (ø)
pty/pty_windows.go 70.14% <0.00%> (ø)
cli/cliui/cliui_darwin.go 0.00% <0.00%> (ø)
cli/ssh_windows.go 0.00% <0.00%> (ø)
agent/usershell/usershell_darwin.go 100.00% <0.00%> (ø)
coderd/provisionerdaemons.go 62.79% <0.00%> (+0.50%) ⬆️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 441ffd6...122281f. Read the comment docs.

@BrunoQuaresma BrunoQuaresma enabled auto-merge (squash) April 26, 2022 19:04
@BrunoQuaresma BrunoQuaresma merged commit 454ccf7 into main Apr 26, 2022
@BrunoQuaresma BrunoQuaresma deleted the bq/remove-name-field branch April 26, 2022 19:04
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
@BrunoQuaresma @kylecarbs
refactor: remove the user name (#1185)
e6a9821
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.
3 participants
@BrunoQuaresma @kylecarbs @misskniss