chore: remove most usage of PropsWithChildren
#11859
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there are a lot of places where we use
PropsWithChildren
, and it either...children
prop)children
), making the code slightly harder to decipherI propose that...
PropsWithChildren
should only be used ungenerically, whenchildren?: ReactNode
is the the only prop accepted by the component.children?: ReactNode
, it must declare it's own props type, and not usePropsWithChildren