ci: fix winget-release workflow #11865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed #11842 Based on the same idea as in microsoft/devhome#2167
|
@mdanish-kh, I would appreciate it if you could look before I merge this. |
mdanish-kh
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
Looks good, this should resolve winget-create's failure (although I haven't been able to test it out). I would suggest kicking off a re-run after merging this, the PR won't get created since Coder v2.7.2 is already in the repo, but we would be able to see if the original error reproduces or not.
|
A rerun of the failed workflow will not use the latest version. The release workflow only gets triggered on a release. So let's see what happens. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11842
Based on the same idea as in microsoft/devhome#2167