Skip to content

chore(dogfood): use built-in VS Code Desktop button over the module #11869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2024
Merged

chore(dogfood): use built-in VS Code Desktop button over the module #11869

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
chore(dogfood): use built-in VS Code Desktop button over the module 
We were using the VS Code Desktop [module](https://registry.coder.com/modules/vscode-desktop) instead of the built-in button. As most users would use the built-in button, we should dogfood that.
  • Loading branch information
@matifali
matifali authored Jan 28, 2024
commit c0e29c341190cba14eea7de7aa5352070a23077f
11 changes: 0 additions & 11 deletions dogfood/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,13 +129,6 @@ module "jetbrains_gateway" {
default = "GO"
}

module "vscode-desktop" {
source = "registry.coder.com/modules/vscode-desktop/coder"
version = "1.0.2"
agent_id = coder_agent.dev.id
folder = local.repo_dir
}

module "filebrowser" {
source = "registry.coder.com/modules/filebrowser/coder"
version = "1.0.2"
Expand Down Expand Up @@ -173,10 +166,6 @@ resource "coder_agent" "dev" {
}
startup_script_behavior = "blocking"

display_apps {
vscode = false
}

# The following metadata blocks are optional. They are used to display
# information about your workspace in the dashboard. You can remove them
# if you don't want to display any information.
Expand Down