Skip to content

feat(site): display user avatar #11893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jan 30, 2024
Merged

feat(site): display user avatar #11893

merged 9 commits into from
Jan 30, 2024
+216 −105

Conversation

BrunoQuaresma
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma commented Jan 29, 2024 •
edited by matifali
Loading

Close #11437

Before:
Screenshot 2024-01-29 at 11 22 45

After:
Screenshot 2024-01-29 at 11 22 50

@BrunoQuaresma BrunoQuaresma self-assigned this Jan 29, 2024
johnstcn
johnstcn reviewed Jan 29, 2024
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a look at the failing tests. I think your refactor is causing the Username field to be blank.

johnstcn
johnstcn reviewed Jan 29, 2024
View reviewed changes
johnstcn
johnstcn reviewed Jan 30, 2024
View reviewed changes
johnstcn
johnstcn reviewed Jan 30, 2024
View reviewed changes
johnstcn
johnstcn reviewed Jan 30, 2024
View reviewed changes
@mtojek
Copy link
Member

mtojek commented Jan 30, 2024

Reviewing now.

@johnstcn johnstcn self-assigned this Jan 30, 2024
@johnstcn johnstcn requested review from mafredri and removed request for spikecurtis January 30, 2024 15:17
mtojek
mtojek approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@johnstcn johnstcn merged commit dcab6fa into main Jan 30, 2024
@johnstcn johnstcn deleted the bq/replace-user-icon-by-avatar branch January 30, 2024 17:07
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnstcn johnstcn johnstcn left review comments

@mtojek mtojek mtojek approved these changes

@mafredri mafredri Awaiting requested review from mafredri

Assignees

@BrunoQuaresma BrunoQuaresma

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display user avatar on workspace top bar instead of a generic icon
3 participants
@BrunoQuaresma @mtojek @johnstcn